2011/10/20 Arun Raghavan <arun.raghavan at collabora.co.uk>: > On Tue, 2011-10-18 at 12:10 +0200, Maarten Bosmans wrote: >> > 2011/10/18 Wang Xingchao <xingchao.wang at intel.com>: >> >> if all channels have same volume setting, use fast way to >> >> do volume change. this patch intended to work for two formats: >> >> s16ne/s16re. > [...] >> The Orc svolume implementation currently only handles 1ch s16ne (the >> orcify branch also adds 1ch float), so I added a similar test for >> identical channel volumes for the Orc case: >> https://github.com/mkbosmans/pulseaudio/commit/8659d08f22ccaba0c1ca18c0b29744318bf4fe08 >> I like that way (only using one extra variable) a bit better than >> yours (with both same_vol and fast_vol added), but that is not really >> important. > > Were you referring to the code in master? That handles both 1ch and 2ch. Indeed, you're right, that's just me typing in stuff from memory without looking it up. Although the distinction I was trying to make was between s16 and float. Maarten
