Hi, As a general comment, I'd rather avoid introducing a new naming convension with the "ABOUT_TO_ACTIVATE" suffix. We already have _POST, _START and _FINISH suffixes on some hooks, so I'd suggest either a _PRE suffix to match _POST or perhaps just reusing _START (tho' _START does seem to imply there will be a corresponding _FINISH so maybe _PRE is better?) Or maybe we should just rename PA_CORE_HOOK_CARD_PROFILE_CHANGED to PA_CORE_HOOK_CARD_PROFILE_CHANGE_FINISH and then call the new one _START? Opinions welcome here. Other than that, provided this doesn't conflict in any major way with anything David's been doing, this seems fine. Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited http://www.tribalogic.net/ Open Source: Mageia Contributor http://www.mageia.org/ PulseAudio Hacker http://www.pulseaudio.org/ Trac Hacker http://trac.edgewall.org/
