'Twas brillig, and Tanu Kaskinen at 26/03/11 04:12 did gyre and gimble: > On Sat, 2011-03-26 at 00:13 +0000, Colin Guthrie wrote: >> FWIW, the attached patch seems to work for me... simply not ref'ing the >> core. If this is OK, then I'll push it. > > Yep, my bad. I think there's a rule that object A shall not ref object B > if B owns A. And here core owns everything, including the dbus objects. > Nobody should ref core. It's then a bit strange why the core is > refcounted in the first place, but I guess it's because the intention is > to make the Pulseaudio core pluggable into other programs, and those > other programs may want to have multiple references to the Pulseaudio > core object. Cool. Yeah I did kinda wonder why the core was refcounted too when looking into this, but your explanation makes sense (even if it's not use like that at the moment - to the best of my knowledge). Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/]
