[PATCH 0/2] Fix mingw32 compile problems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/18/2011 01:17 AM, Maarten Bosmans wrote:
> 2011/6/17 Fritz Elfert <fritz at fritz-elfert.de>:
>> -----BEGIN PGP SIGNED MESSAGE-----
>[...]
> The patches seem a bit garbled. Fritz, you should check the setting of
> your mail client.
> Both patches can be pulled in one commit from
> git://github.com/mkbosmans/pulseaudio.git mingw32-build
> 
> Maarten

Actually, I specifically disabled wrapping before sending them. What I
didn't realize, was that all my mails are GPG-signed and my enigmail
setup did this inline. Now ive'e changed that to MIME-Multipart with
body and sig in 2 different parts. Shouldn't make a problem anymore...

What I didn't like about git-format-patch that it created several
separate mails. I think multiple commits for a single problem should go
into *one* combined diff....

Meanwhile, I have some more local changes here:

 - Added a new --log-target "windbg" which replaces "syslog" on win32
builds. Logging is done via OutputDebugStringA(). Log output can
watched for example with SysInternal's debugview.

 - Fixed a very annoying (at least for me, while trying to build on Mac
OSX) misbehavior of configure:

The switch --disable-nls was completely ignored. This were actually 2
bugs in M4 macros used by pulseaudio. a) The provided intltool.m4 did
complain about missing intltool even when disabling NLS. b) The
invocation of AM_GLIB_GNU_GETTEXT always enables NLS if it finds any
gettext stuff on the build system even if disabled by --disable-nls.

Ok to post those here, or shall I create a pull request on github?

Cheers,
 -Fritz

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20110620/883975c4/attachment.pgp>


[Index of Archives]     [Linux Audio Users]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux