On Sat, 2011-07-09 at 11:36 +0100, Colin Guthrie wrote: > 'Twas brillig, and Tanu Kaskinen at 07/07/11 20:42 did gyre and gimble: > > On Thu, 2011-07-07 at 10:55 +0100, Colin Guthrie wrote: > >> Some sink flags are really just a product of what callbacks > >> set on the sink. Rather than assert when the flags don't > >> match the callbacks registered, just set them automatically. > > > > For the hw volume/mute flags the automation is a bit broken: the hw > > flags are enabled also for virtual devices that use the volume/mute > > callbacks for something (like adjusting the output stream volume). Many > > virtual devices seem to set the hw volume/mute flags explicitly for some > > reason, so this was broken already before, but for another reason... > > Personally I think this is OK. The flags are really misnamed with "HW" > in them, but really they mean "have volume callbacks". This was how they > were used before (the asserts made sure of this generally) so I think > this is acceptable. If you feel strongly about it tho', please do speak > up and I can reconsider. No, I don't feel strongly about this. -- Tanu
