On Thu, 2011-07-07 at 10:55 +0100, Colin Guthrie wrote: > This allows us to flip from software to hardware volume control as the port's > mixer path dictates. I don't really like the pa_sink_set_flags_from_callbacks() function, because the sink implementations have to remember to call it whenever they change the callbacks. I propose that we add pa_sink_set_get_volume_callback() etc, and do the flag updates and subscription notification inside those functions. What do you think? A somewhat similar thing: I'd add pa_sink_set_decibel_volume() that takes care of sending the subscription notification so the sink implementations wouldn't have to care about that. -- Tanu
