On Thu, Apr 14, 2011 at 3:53 PM, Maarten Bosmans <mkbosmans at gmail.com> wrote: > 2011/4/14 Daniel Mack <zonque at gmail.com>: >> On Thu, Apr 14, 2011 at 12:46 AM, Maarten Bosmans <mkbosmans at gmail.com> wrote: >>> return (fd >= 0) && (fcntl(fd, F_GETFL) != -1); >>> >>> For Windows, both fcntl and F_GETFL are not available. >> >> Sigh. Ok, thanks for the feedback. Attached is a new patch which keeps >> things as they are for Windows but fixes the problem for OS X. > > That should do it, yes. > > +#else /* !OS_IS_WINDOWS */ > Minor: this is not exactly the symbol used in the #ifdef. Ok. > Anyway, isn't the #else only supposed to be used for OSX? In that case > the comment should probably say so. No, it's actually really a workaround for Windows as we don't have fcntl() there. (Just curious - the header file does exist, right? I saw it being included by quite a lot of other source files in the PA tree ...) Daniel -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-pa_poll-Simplify-detection-of-invalid-fds-in-select-.patch Type: application/octet-stream Size: 2612 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20110414/a5456156/attachment.obj>
