On Wed, 2011-04-06 at 11:41 +0300, Tanu Kaskinen wrote: > On Wed, 2011-04-06 at 00:57 +0300, Maarten Bosmans wrote: > > What are the users of this state tracker? Is it only some out-of-tree > > Meego modules? Are you planning to submit those too? At least a > > snippet of how it should be used would be nice. > > The users are mentioned in call-state-tracker.h. I guess I should have > said "See call-state-tracker.h for details." in the commit message. > (Colin, feel free to add that sentence in the commit message, if you > decide to accept this patch.) So yes, only some out-of-tree Meego > modules use the call state tracker. About upstreaming those - there are > no concrete plans that I'm aware of. I guess the only issue is that we > are not confident that the code is clean enough... I was reminded that we actually already have "libmeego-common" (a support library for the out-of-tree modules) in the package that provides the meego modules, and this feature would arguably fit better in libmeego-common than libpulsecore. I would still like to see as much stuff in upstream as possible, so I won't recommend that you reject the patch, but it really isn't a big deal if you do. -- Tanu
