'Twas brillig, and David Henningsson at 13/10/10 07:27 did gyre and gimble: > We have got three confirmations that the patch is working in the bug > below, so I believe it can be safely applied to both master and > stable-queue. Great! Would you mind respinning the patch with a couple more inline comments? I'm a little concerned about the lines such as "channels = channels == 3 ? 6 : PA_MAX(....)" It will be a bit disconcerting to read this in code without really reading the relevant commit message, so I think a small hint towards why this is done would be good here. Or perhaps create a couple macros instead then document the macro definitions? Whatever you prefer, but I think some hints are needed at the code level. Cheers Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/]
