'Twas brillig, and Colin Guthrie at 05/02/10 15:06 did gyre and gimble: > 'Twas brillig, and Tanu Kaskinen at 05/02/10 14:29 did gyre and gimble: >> pe, 2010-02-05 kello 10:11 +0000, Colin Guthrie kirjoitti: >>> I also generate a sink input|source output change subscription message >>> here. This is arguably not "correct" as the sink input itself is not >>> changing, although the rules governing it's routing have. In lieu of a >>> proper subscription system for "routing rules" I just fire this one. >> >> You seem to fire the event unconditionally after > ... >> Is it guaranteed that the previous value is always TRUE? If not, I think >> you should write > > Ahh excellent point. Thanks. Revised patch: http://colin.guthr.ie/git/pulseaudio/commit/?id=6fd2d087585b33dce918e857e9f2635862a0746c -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mandriva Linux Contributor [http://www.mandriva.com/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker [http://trac.edgewall.org/]
