Lennart Poettering wrote: > On Wed, 04.06.08 09:42, Lennart Poettering (lennart at poettering.net) wrote: > >> On Tue, 03.06.08 19:55, svnmailer-noreply at 0pointer.de (svnmailer-noreply at 0pointer.de) wrote: >> >>> Author: coling >>> Date: Tue Jun 3 21:55:01 2008 >>> New Revision: 2495 >>> >>> URL: http://0pointer.de/cgi-bin/viewcvs.cgi?rev=2495&root=pulseaudio&view=rev >>> Log: >>> Also link libpulsecore.la to some libraries (needed for >>> logging). Discovered while compiling with --as-needed >> No, this is not a good idea. libpulsecore is supposed to be used only >> by the PA server, it should not be linked against the client tools >> where padsp is one example of. > > Grrh, forget my complaining please, you seem to have commited the fix > already! > > Sorry for the confusion! No it's OK. I did ask on IRC immediately after the commit to ask why some link against the library and some the files directly and if I'd done this correctly, so I appreciate the response even if I did work it out for myself :D The trouble was I had my systems pulse devel package installed and it didn't mess up the build when I tested it. When I submitted a patched mdv package to our build cluster (we enable --as-needed by default now) it spat out the error and I knew I had a problem and figured it out from there :) Cheers. Col
