On Tue, 03.06.08 19:55, svnmailer-noreply at 0pointer.de (svnmailer-noreply at 0pointer.de) wrote: > Author: coling > Date: Tue Jun 3 21:55:01 2008 > New Revision: 2495 > > URL: http://0pointer.de/cgi-bin/viewcvs.cgi?rev=2495&root=pulseaudio&view=rev > Log: > Also link libpulsecore.la to some libraries (needed for > logging). Discovered while compiling with --as-needed No, this is not a good idea. libpulsecore is supposed to be used only by the PA server, it should not be linked against the client tools where padsp is one example of. > Modified: trunk/src/Makefile.am > URL: http://0pointer.de/cgi-bin/viewcvs.cgi/trunk/src/Makefile.am?rev=2495&root=pulseaudio&r1=2494&r2=2495&view=diff > ============================================================================== > --- trunk/src/Makefile.am (original) > +++ trunk/src/Makefile.am Tue Jun 3 21:55:01 2008 > @@ -640,7 +640,7 @@ > > libpulsedsp_la_SOURCES = utils/padsp.c > libpulsedsp_la_CFLAGS = $(AM_CFLAGS) > -libpulsedsp_la_LIBADD = $(AM_LIBADD) libpulse.la > +libpulsedsp_la_LIBADD = $(AM_LIBADD) libpulse.la libpulsecore.la > libpulsedsp_la_LDFLAGS = -avoid-version Not good. log.[ch] should be added to the SOURCES here. > libpstream_util_la_SOURCES = pulsecore/pstream-util.c pulsecore/pstream-util.h > libpstream_util_la_LDFLAGS = -avoid-version > -libpstream_util_la_LIBADD = $(AM_LIBADD) libpacket.la libpstream.la libtagstruct.la > +libpstream_util_la_LIBADD = $(AM_LIBADD) libpacket.la libpstream.la libtagstruct.la libpulsecore.la This is OK, but not strictly necessary. Lennart -- Lennart Poettering Red Hat, Inc. lennart [at] poettering [dot] net ICQ# 11060553 http://0pointer.net/lennart/ GnuPG 0x1A015CC4
