Hi, On 31-Jan-25 8:37 AM, Sakari Ailus wrote: > Hi folks, > > One patch turned into a set, the second patch being the original one. > > since v3: > > - Add a patch (first one) to switch to unsigned long type for polarity > field and renames it as gpio_flags. > > - Use a polarity_low boolean field for indicating the GPIO polarity. This > is turned to gpio_flags in int3472_get_con_id_and_polarity(). > > - Put the new polarity_low bool field next to the u8's for better struct > packing. > > - Add a patch (last one) to rename "func" as "con_id" which is used > throughout the GPIO framework. Thanks the whole series looks good to me: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> for the series. Regards, Hans p.s. Did you see my remarks about rewriting the INT3472 code to have it do all the power-sequencing itself in the "RFC: How to deal with the INT3472 handshake GPIO found on Intel IPU6 MTL?" thread ?