On Tue, Nov 12, 2024 at 02:38:06PM +0000, Ruhl, Michael J wrote: > > -----Original Message----- > > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > Sent: Monday, November 11, 2024 3:34 AM > > To: Ruhl, Michael J <michael.j.ruhl@xxxxxxxxx> > > Cc: intel-xe@xxxxxxxxxxxxxxxxxxxxx; platform-driver-x86@xxxxxxxxxxxxxxx; > > david.e.box@xxxxxxxxxxxxxxx; ilpo.jarvinen@xxxxxxxxxxxxxxx; > > hdegoede@xxxxxxxxxx; Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>; De Marchi, > > Lucas <lucas.demarchi@xxxxxxxxx> > > Subject: Re: [PATCH 1/2] platform/x86/intel/pmt: allow user offset for PMT > > callbacks > > > > On Fri, Nov 08, 2024 at 03:19:53PM -0500, Michael J. Ruhl wrote: > > > Usage of the telem sysfs file allows for partial reads at an offset. > > > > > > The current callback method returns the buffer starting from offset 0 > > > only. > > > > > > Include the requested offset in the callback. > > > Update the necsessary address calculations with the offset. > > > > ... > > > > > - memcpy_fromio(buf, addr, count); > > > + memcpy_fromio(buf, addr + off, count); > > Hi Andy, > > > This will give an unaligned IO access in some cases. Is it a problem? > > That is a good question. > > I moved this value from the caller to this location. > > So essentially it is "unchanged" from the current usage. Does that answer > the question? Probably. Please, mention this in the commit message. -- With Best Regards, Andy Shevchenko
