Re: [PATCH 1/2] platform/x86/intel/pmt: allow user offset for PMT callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 08, 2024 at 03:19:53PM -0500, Michael J. Ruhl wrote:
> Usage of the telem sysfs file allows for partial reads at
> an offset.
> 
> The current callback method returns the buffer starting
> from offset 0 only.
> 
> Include the requested offset in the callback.
> Update the necsessary address calculations with the offset.

...

> -	memcpy_fromio(buf, addr, count);
> +	memcpy_fromio(buf, addr + off, count);

This will give an unaligned IO access in some cases. Is it a problem?

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux