> Some ideas:
>
> 1) Should there be header version check on the TA and dynamically
> allocate the structure size based on the version of the F/W?
>
This can be done, when the TA versioning upgrade happens, like from
1.3 to 1.4, apart from that there is no header stuff association.
> 2) Or is there a command to the TA that can query the expected output
> size?
>
No, this is just the initial shared memory that the driver allocates
to pass the inputs and the commands to TA.
> 3) Or should the new TA filename be versioned, and the driver has a
> fallback policy?
>
> Whatever the outcome is; I think it's best that if possible this
> change goes back to stable to try to minimize regressions to users as
> distros update linux-firmware. For example Fedora updates this
> monthly, but also tracks stable kernels.
>
Advisory to distros should be to pick the latest PMF TA (note that, I
have not still submitted to new TA FW).
Thanks,
Shyam
>> ---
>> Â drivers/platform/x86/amd/pmf/pmf.h | 2 +-
>> Â 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/amd/pmf/pmf.h
>> b/drivers/platform/x86/amd/pmf/pmf.h
>> index a79808fda1d8..18f12aad46a9 100644
>> --- a/drivers/platform/x86/amd/pmf/pmf.h
>> +++ b/drivers/platform/x86/amd/pmf/pmf.h
>> @@ -106,7 +106,7 @@ struct cookie_header {
>> Â #define PMF_TA_IF_VERSION_MAJORÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â 1
>> Â #define TA_PMF_ACTION_MAXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 32
>> Â #define TA_PMF_UNDO_MAXÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 8
>> -#define TA_OUTPUT_RESERVED_MEMÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â 906
>> +#define TA_OUTPUT_RESERVED_MEMÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â 922
>> Â #define MAX_OPERATION_PARAMSÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â 4
>> Â Â #define PMF_IF_V1Â Â Â Â Â Â Â 1
>
