On Sun, 20 Oct 2024, at 9:05 PM, Armin Wolf wrote: > Am 20.10.24 um 08:50 schrieb Srinivas Pandruvada: > >> Some recent Asus laptops are supporting ASUS Intelligent Performance >> Technology (AIPT). This solution allows users to have maximized CPU >> performance in models with a chassis providing more thermal head room. >> Refer to [1]. >> >> There are major performance issues when Linux is installed on these >> laptops compared to Windows install. One such report is published for >> Graphics benchmarks on Asus ASUS Zenbook S 14 with Lunar Lake >> processors [2]. >> >> By default, these laptops are booting in "Whisper Mode" till OS power >> management or tools change this to other AIPT mode. This "Whisper" mode >> calls to set lower maximum and minimum RAPL (Running Average Power Limit) >> via thermal tables. On Linux this leads to lower performance even when >> platform power profile is "balanced". This "Whisper" mode should >> correspond to "quiet" mode. >> >> So, when AIPT is present change the default mode to "Standard" during >> boot. Map the three platform power profile modes as follows: >> >> Power Profile Mode AIPT mode >> ----------------------------------- >> quiet Whisper >> balanced Standard >> performance Performance >> ------------------------------------ >> >> Here AIPT mode can be detected by checking presese of "FANL" method under >> PNP HID "PNP0C14" and UID "ATK". If AIPT mode is present, this takes >> precedence over the existing VIVO thermal policy. These modes are set >> using "FANL" method. >> >> Although this “FANL” method is not used in the Asus WMI driver, users >> have used this method from user space [3] to set AIPT modes. Used this >> as a reference. >> >> Link: https://www.asus.com/content/laptop-asus-intelligent-performance-technology-aipt/ # [1] >> Reported-by: Michael Larabel <Michael@xxxxxxxxxxxx> >> Closes: https://www.phoronix.com/review/lunar-lake-xe2/5 # [2] >> Link: https://github.com/dominiksalvet/asus-fan-control/issues/151 # [3] >> Tested-by: Casey Bowman <casey.g.bowman@xxxxxxxxx> >> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> >> --- >> drivers/platform/x86/asus-wmi.c | 93 +++++++++++++++++++++++++++++++-- >> 1 file changed, 89 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c >> index 7a48220b4f5a..06689d0f98c7 100644 >> --- a/drivers/platform/x86/asus-wmi.c >> +++ b/drivers/platform/x86/asus-wmi.c >> @@ -100,6 +100,11 @@ module_param(fnlock_default, bool, 0444); >> #define ASUS_THROTTLE_THERMAL_POLICY_SILENT_VIVO 1 >> #define ASUS_THROTTLE_THERMAL_POLICY_OVERBOOST_VIVO 2 >> >> +#define AIPT_STANDARD 0 >> +#define AIPT_WHISPER 1 >> +#define AIPT_PERFORMANCE 2 >> +#define AIPT_FULL_SPEED 3 >> + >> #define PLATFORM_PROFILE_MAX 2 >> >> #define USB_INTEL_XUSB2PR 0xD0 >> @@ -333,6 +338,9 @@ struct asus_wmi { >> struct asus_wmi_debug debug; >> >> struct asus_wmi_driver *driver; >> + acpi_handle acpi_mgmt_handle; >> + int asus_aipt_mode; >> + bool asus_aipt_present; >> }; >> >> /* WMI ************************************************************************/ >> @@ -3804,6 +3812,19 @@ static ssize_t throttle_thermal_policy_store(struct device *dev, >> static DEVICE_ATTR_RW(throttle_thermal_policy); >> >> /* Platform profile ***********************************************************/ >> +static int asus_wmi_write_aipt_mode(struct asus_wmi *asus, int aipt_mode) >> +{ >> + int status; >> + >> + status = acpi_execute_simple_method(asus->acpi_mgmt_handle, "FANL", aipt_mode); >> + if (ACPI_FAILURE(status)) { >> + acpi_handle_info(asus->acpi_mgmt_handle, "FANL execute failed\n"); >> + return -EIO; >> + } >> + >> + return 0; >> +} >> + >> static int asus_wmi_platform_profile_to_vivo(struct asus_wmi *asus, int mode) >> { >> bool vivo; >> @@ -3844,6 +3865,26 @@ static int asus_wmi_platform_profile_mode_from_vivo(struct asus_wmi *asus, int m >> return mode; >> } >> >> +static int asus_wmi_aipt_platform_profile_get(struct asus_wmi *asus, >> + enum platform_profile_option *profile) >> +{ >> + switch (asus->asus_aipt_mode) { >> + case AIPT_STANDARD: >> + *profile = PLATFORM_PROFILE_BALANCED; >> + break; >> + case AIPT_PERFORMANCE: >> + *profile = PLATFORM_PROFILE_PERFORMANCE; >> + break; >> + case AIPT_WHISPER: >> + *profile = PLATFORM_PROFILE_QUIET; >> + break; >> + default: >> + return -EINVAL; >> + } >> + >> + return 0; >> +} >> + >> static int asus_wmi_platform_profile_get(struct platform_profile_handler *pprof, >> enum platform_profile_option *profile) >> { >> @@ -3851,6 +3892,10 @@ static int asus_wmi_platform_profile_get(struct platform_profile_handler *pprof, >> int tp; >> >> asus = container_of(pprof, struct asus_wmi, platform_profile_handler); >> + >> + if (asus->asus_aipt_present) >> + return asus_wmi_aipt_platform_profile_get(asus, profile); >> + >> tp = asus->throttle_thermal_policy_mode; >> >> switch (asus_wmi_platform_profile_mode_from_vivo(asus, tp)) { >> @@ -3874,26 +3919,42 @@ static int asus_wmi_platform_profile_set(struct platform_profile_handler *pprof, >> enum platform_profile_option profile) >> { >> struct asus_wmi *asus; >> - int tp; >> + int ret = 0, tp, aipt_mode; >> >> asus = container_of(pprof, struct asus_wmi, platform_profile_handler); >> >> switch (profile) { >> case PLATFORM_PROFILE_PERFORMANCE: >> tp = ASUS_THROTTLE_THERMAL_POLICY_OVERBOOST; >> + aipt_mode = AIPT_PERFORMANCE; >> break; >> case PLATFORM_PROFILE_BALANCED: >> tp = ASUS_THROTTLE_THERMAL_POLICY_DEFAULT; >> + aipt_mode = AIPT_STANDARD; >> break; >> case PLATFORM_PROFILE_QUIET: >> tp = ASUS_THROTTLE_THERMAL_POLICY_SILENT; >> + aipt_mode = AIPT_WHISPER; >> break; >> default: >> return -EOPNOTSUPP; >> } >> >> - asus->throttle_thermal_policy_mode = asus_wmi_platform_profile_to_vivo(asus, tp); >> - return throttle_thermal_policy_write(asus); >> + if (asus->asus_aipt_present) { >> + ret = asus_wmi_write_aipt_mode(asus, aipt_mode); >> + if (!ret) { >> + asus->asus_aipt_mode = aipt_mode; >> + goto skip_vivo; >> + } >> + } >> + >> + if (asus->throttle_thermal_policy_dev) { >> + asus->throttle_thermal_policy_mode = asus_wmi_platform_profile_to_vivo(asus, tp); >> + ret = throttle_thermal_policy_write(asus); >> + } >> + >> +skip_vivo: >> + return ret; >> } >> >> static int platform_profile_setup(struct asus_wmi *asus) >> @@ -3905,7 +3966,7 @@ static int platform_profile_setup(struct asus_wmi *asus) >> * Not an error if a component platform_profile relies on is unavailable >> * so early return, skipping the setup of platform_profile. >> */ >> - if (!asus->throttle_thermal_policy_dev) >> + if (!asus->throttle_thermal_policy_dev && !asus->asus_aipt_present) >> return 0; >> >> dev_info(dev, "Using throttle_thermal_policy for platform_profile support\n"); >> @@ -4538,6 +4599,7 @@ static int asus_wmi_sysfs_init(struct platform_device *device) >> static int asus_wmi_platform_init(struct asus_wmi *asus) >> { >> struct device *dev = &asus->platform_device->dev; >> + struct acpi_device *adev; >> char *wmi_uid; >> int rv; >> >> @@ -4593,6 +4655,29 @@ static int asus_wmi_platform_init(struct asus_wmi *asus) >> asus_wmi_set_devstate(ASUS_WMI_DEVID_CWAP, >> asus->driver->quirks->wapf, NULL); >> >> + /* >> + * Check presence of Intelligent Performance Technology (AIPT). >> + * If present store acpi handle and set asus_aipt_present to true. >> + */ >> + adev = acpi_dev_get_first_match_dev("PNP0C14", "ATK", -1); > > Is there really no way of changing the AIPT mode through the WMI interface? > I would prefer using the WMI interface if available, since the firmware might > assume that FANL is only called through the WMI interface. > > Do you have a acpidump from a affected device? > > Thanks, > Armin Wolf > >> + if (adev) { >> + acpi_handle handle = acpi_device_handle(adev); >> + >> + acpi_dev_put(adev); >> + >> + if (!acpi_has_method(handle, "FANL")) >> + return 0; Quite a few laptops have this method available, but may not actually do anything. Such as the following: FX517ZM-dsdt.dsl 92885: Method (FANL, 1, Serialized) 92886- { 92887- Return (One) 92888- } While this one does (zenbook duo): UX8402.dsl 88837: Method (FANL, 1, Serialized) 88838- { 88839- ODV0 = Arg0 88840- If ((^^PC00.PEG1.PXP._STA == One)) -- 89041: Return (FANL (IIA0)) 89042- } 89043- 89044- If ((Local0 == 0x4647574D)) -- 89604: FANL (IIA1) 89605- Return (One) 89606- } 89607- I've discovered the majority of WMI methods, you can see them here: https://gitlab.com/asus-linux/reverse-engineering/-/blob/master/WMI_SPEC.md?ref_type=heads There is a "whisper mode" WMI method, but I've not done much around it. I also have a large collection of DSL if that is helpful https://gitlab.com/asus-linux/reverse-engineering/-/tree/master/dsl-collection?ref_type=heads It seems that because I have access only to the ROG dlls at this time I may have missed the WMI method: 0x00110019, this is likely what you need as it gets FANF, and sets FANL ❯ rg 0x00110019 -B3 -A3 UX8402.dsl 89281- Return (0x00010000) 89282- } 89283- 89284: If ((IIA0 == 0x00110019)) 89285- { 89286- Local0 = FANF /* \_SB_.FANF */ 89287- Local1 = 0x00070000 -- 89599- Return (One) 89600- } 89601- 89602: If ((IIA0 == 0x00110019)) 89603- { 89604- FANL (IIA1) 89605- Return (One) Hopefully this is helpful, Regards, Luke. P.S: If any info is discovered that I am lacking in my repo it would be highly appreciated if a PR added it. >> + asus->acpi_mgmt_handle = handle; >> + asus->asus_aipt_present = true; >> + dev_info(dev, "ASUS Intelligent Performance Technology (AIPT) is present\n"); >> + /* >> + * Set the mode corresponding to default Linux platform power >> + * profile Balanced >> + */ >> + asus_wmi_write_aipt_mode(asus, AIPT_STANDARD); >> + } >> + >> return 0; >> } >>
