>> … >>> +++ b/drivers/platform/x86/asus-armoury.h >>> @@ -0,0 +1,146 @@ >> … >>> +#ifndef _ASUS_BIOSCFG_H_ >>> +#define _ASUS_BIOSCFG_H_ >> … >> >> I suggest to omit leading underscores from such identifiers. >> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier … > the link is C standard, not kernel C right? Advice is offered in such a direction. > Pretty much everything I look at in the kernel seems to use the leading underscores. How much would you like to care for standard compliance concerns together with your software developments? Regards, Markus
