On Fri, 27 Sep 2024, at 7:10 AM, Markus Elfring wrote: > … > > +++ b/drivers/platform/x86/asus-armoury.h > > @@ -0,0 +1,146 @@ > … > > +#ifndef _ASUS_BIOSCFG_H_ > > +#define _ASUS_BIOSCFG_H_ > … > > I suggest to omit leading underscores from such identifiers. > https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier Hi Markus, the link is C standard, not kernel C right? Pretty much everything I look at in the kernel seems to use the leading underscores. Regards, Luke.