Hi, On 5/15/24 6:53 AM, Andy Shevchenko wrote: > On Tue, May 14, 2024 at 9:03 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> >> Some MeeGoPad top-set boxes have an ANX7428 Type-C Switch for USB3.1 Gen 1 >> and DisplayPort over Type-C alternate mode support. >> >> The ANX7428 has a microcontroller which takes care of the PD negotiation >> and automatically sets the builtin Crosspoint Switch to send the right >> signal to the 4 highspeed pairs of the Type-C connector. It also takes >> care of HPD and AUX channel routing for DP alternate mode. >> >> IOW the ANX7428 operates fully autonomous and to the x5-Z8350 SoC >> things look like there simple is a USB-3 Type-A connector and a >> separate DisplayPort connector. Except that the BIOS does not >> power on the ANX7428 at boot (meh). >> >> Add a driver to power on the ANX7428. This driver is added under >> drivers/platform/x86 rather than under drivers/usb/typec for 2 reasons: >> >> 1. This driver is specifically written to work with how the ANX7428 is >> described in the ACPI tables of the MeeGoPad x86 (Cherry Trail) devices. >> >> 2. This driver only powers on the ANX7428 and does not do anything wrt >> its Type-C functionality. It should be possible to tell the controller >> which data- and/or power-role to negotiate and to swap the role(s) after >> negotiation but the MeeGoPad top-set boxes always draw their power from >> a separate power-connector and they only support USB host-mode. So this >> functionality is unnecessary and due to lack of documentation this is >> tricky to support. > > ... > >> + * DisplayPort over Type-C alternate mode support. >> + * >> + * The ANX7428 has a microcontroller which takes care of the PD >> + * negotiation and automatically sets the builtin Crosspoint Switch >> + * to send the right signal to the 4 highspeed pairs of the Type-C >> + * connector. It also takes care of HPD and AUX channel routing for >> + * DP alternate mode. >> + * >> + * IOW the ANX7428 operates fully autonomous and to the x5-Z8350 SoC >> + * things look like there simple is a USB-3 Type-A connector and a > > simply > >> + * separate DisplayPort connector. Except that the BIOS does not >> + * power on the ANX7428 at boot. This driver takes care of powering >> + * on the ANX7428. >> + * >> + * It should be possible to tell the micro-controller which data- and/or >> + * power-role to negotiate and to swap the role(s) after negotiation >> + * but the MeeGoPad top-set boxes always draw their power from a separate >> + * power-connector and they only support USB host-mode. So this functionality >> + * is unnecessary and due to lack of documentation this is tricky to support. >> + * >> + * For a more complete ANX7428 driver see drivers/usb/misc/anx7418/ of >> + * the LineageOS kernel for the LG G5 (International) aka the LG H850: >> + * https://github.com/LineageOS/android_kernel_lge_msm8996/ > > ... > >> +#include <linux/acpi.h> >> +#include <linux/bits.h> >> +#include <linux/delay.h> > > + dev_printk.h > >> +#include <linux/dmi.h> > > + err.h > >> +#include <linux/gpio/consumer.h> >> +#include <linux/i2c.h> >> +#include <linux/iopoll.h> >> +#include <linux/module.h> > > + types.h > > ... > >> +static struct i2c_driver anx7428_driver = { >> + .driver = { >> + .name = "meegopad_anx7428", >> + .acpi_match_table = anx7428_acpi_match, >> + }, >> + .probe = anx7428_probe, >> +}; > >> + > > Unneeded blank line. > >> +module_i2c_driver(anx7428_driver); > > ... > > You can fold the above into the current one, no need to resend. Thank you for the review. I've squashed fixes for all of these into the existing commit. Regards, Hans
