Re: [PATCH v6 1/2] platform/x86: dell-smbios: Add helper for checking supported commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 11.05.24 um 04:36 schrieb Lyndon Sanche:

Add symbol to check if a specific class of smbios command is supported.

Signed-off-by: Lyndon Sanche <lsanche@xxxxxxxxxx>
---
  drivers/platform/x86/dell/dell-smbios-base.c | 6 ++++++
  drivers/platform/x86/dell/dell-smbios.h      | 1 +
  2 files changed, 7 insertions(+)

diff --git a/drivers/platform/x86/dell/dell-smbios-base.c b/drivers/platform/x86/dell/dell-smbios-base.c
index e61bfaf8b5c4..6ae09d7f76fb 100644
--- a/drivers/platform/x86/dell/dell-smbios-base.c
+++ b/drivers/platform/x86/dell/dell-smbios-base.c
@@ -350,6 +350,12 @@ void dell_laptop_call_notifier(unsigned long action, void *data)
  }
  EXPORT_SYMBOL_GPL(dell_laptop_call_notifier);

+bool dell_laptop_check_supported_cmds(u16 class)
+{

Hi,

the function dell_smbios_call_filter() says that classes above 30 are always unsupported,
so please check this here too.

Also please rename the function to something like dell_smbios_class_is_supported().

Other than that:
Reviewed-by: Armin Wolf <W_Armin@xxxxxx>

+	return da_supported_commands & (1 << class);
+}
+EXPORT_SYMBOL_GPL(dell_laptop_check_supported_cmds);
+
  static void __init parse_da_table(const struct dmi_header *dm)
  {
  	/* Final token is a terminator, so we don't want to copy it */
diff --git a/drivers/platform/x86/dell/dell-smbios.h b/drivers/platform/x86/dell/dell-smbios.h
index eb341bf000c6..63116671eada 100644
--- a/drivers/platform/x86/dell/dell-smbios.h
+++ b/drivers/platform/x86/dell/dell-smbios.h
@@ -73,6 +73,7 @@ enum dell_laptop_notifier_actions {
  int dell_laptop_register_notifier(struct notifier_block *nb);
  int dell_laptop_unregister_notifier(struct notifier_block *nb);
  void dell_laptop_call_notifier(unsigned long action, void *data);
+bool dell_laptop_check_supported_cmds(u16 class);

  /* for the supported backends */
  #ifdef CONFIG_DELL_SMBIOS_WMI





[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux