Internal Use - Confidential +AD4- -----Original Message----- +AD4- From: Lyndon Sanche +ADw-lsanche+AEA-lyndeno.ca+AD4- +AD4- Sent: Saturday, May 11, 2024 11:54 PM +AD4- To: Shen, Yijun +ADw-Yijun+AF8-Shen+AEA-Dell.com+AD4- +AD4- Cc: Mario Limonciello +ADw-mario.limonciello+AEA-amd.com+AD4AOw- Pali Roh+AOE-r +AD4- +ADw-pali+AEA-kernel.org+AD4AOw- Armin Wolf +ADw-W+AF8-Armin+AEA-gmx.de+AD4AOw- +AD4- srinivas.pandruvada+AEA-linux.intel.com+ADs- Ilpo J+AOQ-rvinen +AD4- +ADw-ilpo.jarvinen+AEA-linux.intel.com+AD4AOw- kernel test robot +ADw-lkp+AEA-intel.com+AD4AOw- Hans de +AD4- Goede +ADw-hdegoede+AEA-redhat.com+AD4AOw- Matthew Garrett +ADw-mjg59+AEA-srcf.ucam.org+AD4AOw- +AD4- Jonathan Corbet +ADw-corbet+AEA-lwn.net+AD4AOw- Heiner Kallweit +AD4- +ADw-hkallweit1+AEA-gmail.com+AD4AOw- Vegard Nossum +ADw-vegard.nossum+AEA-oracle.com+AD4AOw- +AD4- platform-driver-x86+AEA-vger.kernel.org+ADs- LKML +ADw-linux-kernel+AEA-vger.kernel.org+AD4AOw- +AD4- Dell Client Kernel +ADw-Dell.Client.Kernel+AEA-dell.com+AD4- +AD4- Subject: RE: +AFs-PATCH v5+AF0- platform/x86: dell-laptop: Implement platform+AF8-profile +AD4- +AD4- +AD4- +AFs-EXTERNAL EMAIL+AF0- +AD4- +AD4- +AD4- +AD4- On May 11, 2024 9:22:23+IC8-a.m. MDT, +ACI-Shen, Yijun+ACI- +ADw-Yijun.Shen+AEA-dell.com+AD4- +AD4- wrote: +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- +AD4-Internal Use - Confidential +AD4- +AD4APg- -----Original Message----- +AD4- +AD4APg- From: Lyndon Sanche +ADw-lsanche+AEA-lyndeno.ca+AD4- +AD4- +AD4APg- Sent: Saturday, May 11, 2024 9:49 AM +AD4- +AD4APg- To: Shen, Yijun +ADw-Yijun+AF8-Shen+AEA-Dell.com+AD4- +AD4- +AD4APg- Cc: Mario Limonciello +ADw-mario.limonciello+AEA-amd.com+AD4AOw- Pali Roh+AOE-r +AD4- +AD4APg- +ADw-pali+AEA-kernel.org+AD4AOw- Armin Wolf +ADw-W+AF8-Armin+AEA-gmx.de+AD4AOw- +AD4- +AD4APg- srinivas.pandruvada+AEA-linux.intel.com+ADs- Ilpo J+AOQ-rvinen +AD4- +AD4APg- +ADw-ilpo.jarvinen+AEA-linux.intel.com+AD4AOw- kernel test robot +ADw-lkp+AEA-intel.com+AD4AOw- +AD4- +AD4APg- Hans de Goede +ADw-hdegoede+AEA-redhat.com+AD4AOw- Matthew Garrett +AD4- +AD4APg- +ADw-mjg59+AEA-srcf.ucam.org+AD4AOw- Jonathan Corbet +ADw-corbet+AEA-lwn.net+AD4AOw- Heiner +AD4- +AD4APg- Kallweit +ADw-hkallweit1+AEA-gmail.com+AD4AOw- Vegard Nossum +AD4- +AD4APg- +ADw-vegard.nossum+AEA-oracle.com+AD4AOw- platform-driver-x86+AEA-vger.kernel.org+ADs- +AD4- LKML +AD4- +AD4APg- +ADw-linux-kernel+AEA-vger.kernel.org+AD4AOw- Dell Client Kernel +AD4- +AD4APg- +ADw-Dell.Client.Kernel+AEA-dell.com+AD4- +AD4- +AD4APg- Subject: Re: +AFs-PATCH v5+AF0- platform/x86: dell-laptop: Implement +AD4- +AD4APg- platform+AF8-profile +AD4- +AD4APg- +AD4- +AD4APg- +AD4- +AD4APg- +AFs-EXTERNAL EMAIL+AF0- +AD4- +AD4APg- +AD4- +AD4APg- +AD4- +AD4APg- +AD4- +AD4APg- On Thu, May 9 2024 at 09:10:51 AM -06:00:00, Lyndon Sanche +AD4- +AD4APg- +ADw-lsanche+AEA-lyndeno.ca+AD4- wrote: +AD4- +AD4APg- +AD4- On Wed, May 8, 2024, at 8:24 AM, Shen, Yijun wrote: +AD4- +AD4APg- +AD4APg- Hi Lyndon, +AD4- +AD4APg- +AD4APg- +AD4- +AD4APg- +AD4APg- Thanks for working on this patch. +AD4- +AD4APg- +AD4APg- +AD4- +AD4APg- +AD4APg- +AD4- +AD4APg- +AD4APg- Dell side has an initial testing with this patch on some +AD4- +AD4APg- +AD4APg- laptops, it looks good. While changing the platform profile: +AD4- +AD4APg- +AD4APg- 1. The corresponding USTT option in BIOS will be changed. +AD4- +AD4APg- +AD4APg- 2. thermald will not be impacted. The related PSVT and ITMT will +AD4- +AD4APg- +AD4APg- be loaded. +AD4- +AD4APg- +AD4APg- Some Dell DTs does not have the USTT, Dell'll have a check if +AD4- +AD4APg- +AD4APg- nothing is broken. +AD4- +AD4APg- +AD4APg- +AD4- +AD4APg- +AD4APg- Additional, with this patch, follow behavior is found: +AD4- +AD4APg- +AD4APg- 1. For example, the platform profile is quiet. +AD4- +AD4APg- +AD4APg- 2. Reboot the system and change the USTT to performance. +AD4- +AD4APg- +AD4APg- 3. Boot to desktop, the platform profile is +ACI-quiet+ACI-, the USTT +AD4- +AD4APg- +AD4APg- will be changed back to +ACI-quiet+ACI-. +AD4- +AD4APg- +AD4APg- This looks like not a proper user experience. The platform +AD4- +AD4APg- +AD4APg- profile should honor the BIOS setting, aka, the platform profile +AD4- +AD4APg- +AD4APg- should be switched to +ACI-performance+ACI-. +AD4- +AD4APg- +AD4- +AD4- +AD4APg- +AD4- Hello: +AD4- +AD4APg- +AD4- +AD4- +AD4APg- +AD4- Thank you for your email. This is definitely undesirable behaviour, +AD4- +AD4APg- +AD4- I will have a look at the code to see why this is happening. Does +AD4- +AD4APg- +AD4- it always revert to quiet on boot, or always the mode that you had +AD4- +AD4APg- +AD4- switched to prior to reboot? +AD4- +AD4APg- +AD4- +AD4- +AD4APg- +AD4- Do you happen to have power-profiles-daemon or something similar +AD4- +AD4APg- +AD4- running? My understanding is it remembers profiles across reboots, +AD4- +AD4APg- +AD4- this could potentially also revert the profile back to what it was. +AD4- +AD4APg- +AD4- See this release for details: +AD4- +AD4APg- +AD4- https://urldefense.com/v3/+AF8AXw-https://gitlab.freedesktop.org/upower/p +AD4- +AD4APg- +AD4- owe +AD4- +AD4APg- +AD4- r-profiles-daemon/-/releases/0.9.0+AF8AXwA7ACEAIQ-LpKI+ACE-jUAEHb-9foumkcmPlEKD6tn +AD4- +AD4APg- +AD4- QrZ sqjB1sXdPDsYvH2fJ- +AD4- gPV6G35MUtDW4q3xhlJ4IeLcIgmVpb3ztXqaOg8+ACQ- +AD4- +AD4APg- +AD4- +AFs-gitlab+AFs-.+AF0-freedesktop+AFs-.+AF0-org+AF0- +AD4- +AD4APg- +AD4- +AD4- +AD4APg- +AD4- I will assume there is a bug in my code at this point. I will test +AD4- +AD4APg- +AD4- with and without ppd running on my system to see if it changes +AD4- +AD4APg- +AD4- across reboots. +AD4- +AD4APg- +AD4- +AD4- +AD4APg- +AD4- Are USTT settings exposed in your BIOS configuration menu? On my +AD4- +AD4APg- +AD4- laptop they are not and I have to use smbios-thermal-ctl. +AD4- +AD4APg- +AD4- +AD4- +AD4APg- +AD4- Thank you, +AD4- +AD4APg- +AD4- +AD4- +AD4APg- +AD4- Lyndon +AD4- +AD4APg- +AD4- +AD4APg- Hi Yijun: +AD4- +AD4APg- +AD4- +AD4APg- I tested this on my computer (XPS 9560). I do not have access to the +AD4- +AD4APg- USTT settings in the BIOS screen so to substitute that, I booted +AD4- +AD4APg- without the patch and set the USTT manually using smbios-thermal-ctl. +AD4- +AD4APg- Here are my findings: +AD4- +AD4APg- +AD4- +AD4APg- Scenario +ACM-1: Without power-profiles-daemon (ppd) running +AD4- +AD4APg- +AD4- +AD4APg- 1. Boot with patch, set platform+AF8-profile to quiet 2. Boot without +AD4- +AD4APg- patch applied (no platform+AF8-profile) +AD4- +AD4APg- - smbios-thermal-ctl confirms USTT is set to quiet +AD4- +AD4APg- - use smbios-thermal-ctl to set USTT to performance +AD4- +AD4APg- - confirm set to performance +AD4- +AD4APg- 3. Boot with patch again +AD4- +AD4APg- - platform+AF8-profile is set to performance +AD4- +AD4APg- +AD4- +AD4APg- Scenario +ACM-2: With ppd running +AD4- +AD4APg- 1. Boot with patch, set platform+AF8-profile to performance with ppd +AD4- +AD4APg- - Confirm platform+AF8-profile is performance 2. Boot without patch +AD4- +AD4APg- applied (no +AD4- +AD4APg- platform+AF8-profile) +AD4- +AD4APg- - smbios-thermal-ctl confirms USTT is set to performance +AD4- +AD4APg- - ppd reverts to balanced (only controlling intel+AF8-pstate in this +AD4- +AD4APg- case) +AD4- +AD4APg- - use smbios-thermal-ctl to set USTT to quiet +AD4- +AD4APg- - confirm set to quiet +AD4- +AD4APg- 3. Boot with patch again +AD4- +AD4APg- - platform+AF8-profile and ppd is set to performance +AD4- +AD4APg- +AD4- +AD4APg- In my case, the setting in the smbios is honored if it was switched +AD4- +AD4APg- with another method. When using a userspace program that manipulates +AD4- +AD4APg- the platform+AF8-profile, the program seems to remember the previous +AD4- +AD4APg- state and switch to that. +AD4- +AD4APg- +AD4- +AD4APg- So I do not think there is a bug in this patch related to this issue, +AD4- +AD4APg- at least in my case. Please let me know if you have any questions. +AD4- +AD4APg- +AD4- +AD4APg- Thanks, +AD4- +AD4APg- +AD4- +AD4APg- Lyndon +AD4- +AD4APg- +AD4- +AD4APg- +AD4- +AD4APg- +AD4- +AD4-Hi Lyndon, +AD4- +AD4- +AD4- +AD4- I've made a video recorder of the issue: +AD4- +AD4- +AD4- https://urldefense.com/v3/+AF8AXw-https://dell.box.com/s/3f3znz1z8c6htbcll9juj6ty +AD4- yu0zvvut+AF8AXwA7ACEAIQ-LpKI+ACE-nHHxFbxzG-rJX+AF8-KZsebMC7ZcJU0WhNhkpXn-pk6nu-sUF38- +AD4- RXz6x3YkALgzS4jnUP9TIWIu4mX+AF8-6cSDbwQ+ACQ- +AFs-dell+AFs-.+AF0-box+AFs-.+AF0-com+AF0- My test +AD4- environment is that I freshly installed the Fedora 40 and will not do any online +AD4- updates. Then install the kernel with the v5 patch applied. +AD4- +AD4- +AD4- +AD4- XPS 9560 is a pretty old system which is RTS with 2017. No USTT setting in +AD4- the BIOS is expected. +AD4- +AD4- I've a check that the Dell system, at least shipped from 2022, the USTT +AD4- setting will be valid in the BIOS. The system used in above link, it is Latitude +AD4- 7350 which is shipped by 2024 April. +AD4- +AD4- +AD4- +AD4- I think the key point to duplicate of this issue that, the USTT needs to be +AD4- changed under BIOS but not under the Linux OS. +AD4- +AD4- +AD4- +AD4-Thanks +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- +AD4- Thanks for the video. +AD4- +AD4- Fedora 40 has power-profiles-daemon enabled by default AFAIK. This would +AD4- be changing the platform profile at load to match the last known state. +AD4- +AD4- Are you able to rerun this test with PPD disabled? Just in case it is a difference +AD4- between setting it in BIOS and smbios-thermal-ctl. +AD4- +AD4- Thanks, +AD4- +AD4- Lyndon If disable the PPD, the issue is gone. Thanks
