Internal Use - Confidential +AD4- -----Original Message----- +AD4- From: Limonciello, Mario +ADw-mario.limonciello+AEA-amd.com+AD4- +AD4- Sent: Saturday, May 11, 2024 11:13 PM +AD4- To: Shen, Yijun +ADw-Yijun+AF8-Shen+AEA-Dell.com+AD4AOw- Lyndon Sanche +AD4- +ADw-lsanche+AEA-lyndeno.ca+AD4- +AD4- Cc: pali+AEA-kernel.org+ADs- W+AF8-Armin+AEA-gmx.de+ADs- +AD4- srinivas.pandruvada+AEA-linux.intel.com+ADs- ilpo.jarvinen+AEA-linux.intel.com+ADs- +AD4- lkp+AEA-intel.com+ADs- Hans de Goede +ADw-hdegoede+AEA-redhat.com+AD4AOw- Matthew Garrett +AD4- +ADw-mjg59+AEA-srcf.ucam.org+AD4AOw- Jonathan Corbet +ADw-corbet+AEA-lwn.net+AD4AOw- Heiner Kallweit +AD4- +ADw-hkallweit1+AEA-gmail.com+AD4AOw- Vegard Nossum +ADw-vegard.nossum+AEA-oracle.com+AD4AOw- +AD4- platform-driver-x86+AEA-vger.kernel.org+ADs- linux-kernel+AEA-vger.kernel.org+ADs- Dell Client +AD4- Kernel +ADw-Dell.Client.Kernel+AEA-dell.com+AD4- +AD4- Subject: Re: +AFs-PATCH v5+AF0- platform/x86: dell-laptop: Implement platform+AF8-profile +AD4- +AD4- +AD4- +AFs-EXTERNAL EMAIL+AF0- +AD4- +AD4- +AD4- +AD4- On 5/11/2024 10:05 AM, Shen, Yijun wrote: +AD4- +AD4- +AD4- +AD4- Internal Use - Confidential +AD4- +AD4APg- -----Original Message----- +AD4- +AD4APg- From: Mario Limonciello +ADw-mario.limonciello+AEA-amd.com+AD4- +AD4- +AD4APg- Sent: Wednesday, May 8, 2024 11:53 PM +AD4- +AD4APg- To: Shen, Yijun +ADw-Yijun+AF8-Shen+AEA-Dell.com+AD4AOw- Lyndon Sanche +AD4- +AD4APg- +ADw-lsanche+AEA-lyndeno.ca+AD4- +AD4- +AD4APg- Cc: pali+AEA-kernel.org+ADs- W+AF8-Armin+AEA-gmx.de+ADs- +AD4- +AD4APg- srinivas.pandruvada+AEA-linux.intel.com+ADs- ilpo.jarvinen+AEA-linux.intel.com+ADs- +AD4- +AD4APg- lkp+AEA-intel.com+ADs- Hans de Goede +ADw-hdegoede+AEA-redhat.com+AD4AOw- Matthew +AD4- Garrett +AD4- +AD4APg- +ADw-mjg59+AEA-srcf.ucam.org+AD4AOw- Jonathan Corbet +ADw-corbet+AEA-lwn.net+AD4AOw- Heiner +AD4- +AD4APg- Kallweit +ADw-hkallweit1+AEA-gmail.com+AD4AOw- Vegard Nossum +AD4- +AD4APg- +ADw-vegard.nossum+AEA-oracle.com+AD4AOw- platform-driver-x86+AEA-vger.kernel.org+ADs- +AD4- +AD4APg- linux-kernel+AEA-vger.kernel.org+ADs- Dell Client Kernel +AD4- +AD4APg- +ADw-Dell.Client.Kernel+AEA-dell.com+AD4- +AD4- +AD4APg- Subject: Re: RE: +AFs-PATCH v5+AF0- platform/x86: dell-laptop: Implement +AD4- +AD4APg- platform+AF8-profile +AD4- +AD4APg- +AD4- +AD4APg- +AD4- +AD4APg- +AFs-EXTERNAL EMAIL+AF0- +AD4- +AD4APg- +AD4- +AD4APg- On 5/8/2024 09:24, Shen, Yijun wrote: +AD4- +AD4APgA+- Hi Lyndon, +AD4- +AD4APgA+- +AD4- +AD4APgA+- Thanks for working on this patch. +AD4- +AD4APgA+- +AD4- +AD4APgA+AD4- +AD4- +AD4APgA+- Dell side has an initial testing with this patch on some laptops, +AD4- +AD4APgA+- it looks +AD4- +AD4APg- good. While changing the platform profile: +AD4- +AD4APgA+- 1. The corresponding USTT option in BIOS will be changed. +AD4- +AD4APgA+- 2. thermald will not be impacted. The related PSVT and ITMT will be +AD4- loaded. +AD4- +AD4APgA+- Some Dell DTs does not have the USTT, Dell'll have a check if +AD4- +AD4APgA+- nothing is +AD4- +AD4APg- broken. +AD4- +AD4APg- +AD4- +AD4APg- Hi Alex+ACE- +AD4- +AD4APg- +AD4- +AD4APg- Have you had a check both on both your AMD laptops and workstations +AD4- +AD4APg- too, or just the Intel ones? I think it would be good to make sure +AD4- +AD4APg- it's getting the correct experience in both cases. +AD4- +AD4APg- +AD4- +AD4- Hi Mario, +AD4- +AD4- +AD4- +AD4- I've a check for this, for both laptop and workstation, the dell+AF8-laptop +AD4- module will not be loaded. So, AMD platform will not be impacted by this +AD4- patch series. +AD4- +AD4- Follow is one example output with workstation. +AD4- +AD4- +ACM-lsmod +AHw- grep dell +AD4- +AD4- dell+AF8-wmi 28672 0 +AD4- +AD4- dell+AF8-smbios 32768 1 dell+AF8-wmi +AD4- +AD4- dcdbas 20480 1 dell+AF8-smbios +AD4- +AD4- dell+AF8-wmi+AF8-descriptor 20480 2 dell+AF8-wmi,dell+AF8-smbios +AD4- +AD4- sparse+AF8-keymap 12288 1 dell+AF8-wmi +AD4- +AD4- ledtrig+AF8-audio 12288 3 snd+AF8-ctl+AF8-led,snd+AF8-hda+AF8-codec+AF8-generic,dell+AF8-wmi +AD4- +AD4- video 73728 2 dell+AF8-wmi,nvidia+AF8-modeset +AD4- +AD4- wmi 40960 5 +AD4- video,dell+AF8-wmi,wmi+AF8-bmof,dell+AF8-smbios,dell+AF8-wmi+AF8-descriptor +AD4- +AD4- +AD4- +AD4- Ah+ADs- right that makes sense. In that case, is dell-laptop even the right place for +AD4- this patch series? I would think the same policies for the platform profile +AD4- should be able to apply to desktop/workstation. +AD4- +AD4- The v6 of this series would block smbios-thermal-ctl from working on a +AD4- workstation too. +AD4- +AD4- +AD4APgA+- +AD4- +AD4APgA+- Additional, with this patch, follow behavior is found: +AD4- +AD4APgA+- 1. For example, the platform profile is quiet. +AD4- +AD4APgA+- 2. Reboot the system and change the USTT to performance. +AD4- +AD4APgA+- 3. Boot to desktop, the platform profile is +ACI-quiet+ACI-, the USTT +AD4- +AD4APgA+- will be +AD4- +AD4APg- changed back to +ACI-quiet+ACI-. +AD4- +AD4APgA+- This looks like not a proper user experience. The platform +AD4- +AD4APgA+- profile should +AD4- +AD4APg- honor the BIOS setting, aka, the platform profile should be switched +AD4- +AD4APg- to +ACI-performance+ACI-. +AD4- +AD4APgA+- +AD4- +AD4APg- +AD4- +AD4APg- I agree, this sounds like the initial profile needs to be read from +AD4- +AD4APg- the BIOS settings too. +AD4- +AD4APg- +AD4- +AD4APg- Furthermore I wanted to ask is there also a WMI setting that +AD4- +AD4APg- corresponds to this that dell-wmi-sysman offers? +AD4- +AD4- Yes, Mario, you're right. This thermal setting could also be toggled by dell- +AD4- wmi-sysman. +AD4- +AD4- But, for the Dell consumer AMD laptops, like Alienware, the BIOS is another +AD4- variant which is different with the workstation one. +AD4- +AD4- With this variant BIOS, there is no USTT and also no dell+AF8-wmi/dell-wmi- +AD4- sysman. +AD4- +AD4- +AD4- +AD4APg- I'm wondering if both should be probed in case the SMBIOS one goes +AD4- away one day. +AD4- +AD4- Yep, I think this is a good suggestion. +AD4- +AD4- +AD4- +AD4- Great+ACE- Although something I wonder is if the policy when changed with dell- +AD4- wmi-sysman is immediate or requires a reboot. A lot of the settings in there +AD4- aren't effective until after a reboot. +AD4- +AD4- If this is one of them then it might not be a good idea to make it work for +AD4- both. Hi Mario, Just have a check, the check steps are: 1. stop the thermald 2. run the stress test 3. Toggle the thermal setting between UltraPerformance and Quiet via dell-wmi-sysman 4. Check the CPU FAN speed The system reboot is not needed, the CPU fan speed changes immediately. A screen recorder here: https://dell.box.com/s/p2bhd2b6cv8z5buk9eao3bosgrrp1lf9 Thanks
