Re: [PATCH 1/3] platform/x86/amd: pmf: Decrease error message to debug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mario, Ilpo,

On 4/10/24 4:09 PM, Mario Limonciello wrote:
> ASUS ROG Zephyrus G14 doesn't have _CRS in AMDI0102 device and so
> there are no resources to walk.  This is expected behavior because
> it doesn't support Smart PC.  Decrease error message to debug.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=218685
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>

Thank you, this entire series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

for the series.

Ilpo, since this fixes a bug and does so based on a DMI match,
so the chance for regressions is quite small I believe it
would be best to merge this through the pdx86/fixes branch,
can you pick this series up please ?

Regards,

Hans





> ---
>  drivers/platform/x86/amd/pmf/acpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/amd/pmf/acpi.c b/drivers/platform/x86/amd/pmf/acpi.c
> index d0cf46e2fc8e..60fc71c9fb0f 100644
> --- a/drivers/platform/x86/amd/pmf/acpi.c
> +++ b/drivers/platform/x86/amd/pmf/acpi.c
> @@ -437,7 +437,7 @@ int apmf_check_smart_pc(struct amd_pmf_dev *pmf_dev)
>  
>  	status = acpi_walk_resources(ahandle, METHOD_NAME__CRS, apmf_walk_resources, pmf_dev);
>  	if (ACPI_FAILURE(status)) {
> -		dev_err(pmf_dev->dev, "acpi_walk_resources failed :%d\n", status);
> +		dev_dbg(pmf_dev->dev, "acpi_walk_resources failed :%d\n", status);
>  		return -EINVAL;
>  	}
>  





[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux