Hi, On 4/8/24 5:37 PM, Andy Shevchenko wrote: > Use GPIO_LOOKUP() macro which provides a compound literal > and can be used with dynamic data. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/x86-android-tablets/core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/x86-android-tablets/core.c b/drivers/platform/x86/x86-android-tablets/core.c > index a3415f1c0b5f..3f56a9dcba52 100644 > --- a/drivers/platform/x86/x86-android-tablets/core.c > +++ b/drivers/platform/x86/x86-android-tablets/core.c > @@ -52,10 +52,8 @@ int x86_android_tablet_get_gpiod(const char *chip, int pin, const char *con_id, > return -ENOMEM; > > lookup->dev_id = KBUILD_MODNAME; > - lookup->table[0].key = chip; > - lookup->table[0].chip_hwnum = pin; > - lookup->table[0].con_id = con_id; > - lookup->table[0].flags = active_low ? GPIO_ACTIVE_LOW : GPIO_ACTIVE_HIGH; > + lookup->table[0] = > + GPIO_LOOKUP(chip, pin, con_id, active_low ? GPIO_ACTIVE_LOW : GPIO_ACTIVE_HIGH); > > gpiod_add_lookup_table(lookup); > gpiod = devm_gpiod_get(&x86_android_tablet_device->dev, con_id, dflags);
