On 3/5/2024 02:20, Armin Wolf wrote: > This patch series fixes various issues inside the policy binary > handling code. > The first patch makes sure that a valid error code is returned upon > failing to start the policy engine, while the second patch drops the > usage of readl() on non-io memory. > The last two patches fix a possible out-of-bounds memory access when > parsing the policy binary header. > > All patches are compile-tested only. > > Changes since v2: > - add patches 1 and 3 > > Changes since v1: > - get the full dword instead of only 8 bits when reading the header > - check if the policy buffer also has enough room for storing the length Thank you Armin. Series looks good to me. Reviewed-by: Shyam Sundar S K Shyam-sundar.S-k@xxxxxxx > > Armin Wolf (4): > platform/x86/amd/pmf: Fix return value of > amd_pmf_start_policy_engine() > platform/x86/amd/pmf: Do not use readl() for policy buffer access > platform/x86/amd/pmf: Use struct for cookie header > platform/x86/amd/pmf: Fix possible out-of-bound memory accesses > > drivers/platform/x86/amd/pmf/pmf.h | 6 +++++- > drivers/platform/x86/amd/pmf/tee-if.c | 21 +++++++++++++-------- > 2 files changed, 18 insertions(+), 9 deletions(-) > > -- > 2.39.2 >
