On Mon, Feb 12, 2024 at 9:30 AM Jonathan LoBue <jlobue10@xxxxxxxxx> wrote: > On Sunday, February 11, 2024 9:08:59 AM PST Andy Shevchenko wrote: ... > > No ACPI_PTR() in new code. It's more problematic than helpful. > > > > Above for your information for the future contributions, as I said in > > the other patch comment, I think the better approach is to enumerate > > from an external driver under the PDx86 realm. > > Thanks for the constructive feedback. You're welcome! > I'm working to fix and re-send via > git send-email. I think the ACPI match table method should be okay and > seems pretty standard for a lot of devices. The problem in this case is > that the identifiers are not currently unique to each chip. Yes, that's why this portion is called "DMI quirk". And it does not belong to the driver as such. In some cases we may have it inside the driver, but here, I believe, and Hans can correct me, we may avoid polluting the driver with a quirk. > This is something > that should be rectified with BOSCH and system builders and then in the > future, the ACPI match table(s) can be updated, and the aborting portion > of loading the bmc150 driver for ASUS ROG ALLY can be removed. As I said in a reply to the other patch, it probably will stay forever. -- With Best Regards, Andy Shevchenko
