Hi, The subjects of all patches in the series are very generic. They should have some more specific prefix IMO. Dec 21, 2023 18:21:48 Suma Hegde <suma.hegde@xxxxxxx>: > This is in advance to supporting ACPI based probe. > > In case of non-ACPI driver, hsmp_test() can be > performed either in plat init() or in probe(). > > however, in case of ACPI probing, hsmp_test() cannot > be called in init(), as the mailbox reg offsets and > base addresses are read from ACPI table in the probe(). > > Hence, move hsmp_test() to probe as preparation for > ACPI support. > > Also use hsmp_send_message() directly in hsmp_test() > as the semaphore is already initialized in probe. > > Signed-off-by: Suma Hegde <suma.hegde@xxxxxxx> > Signed-off-by: Naveen Krishna Chatradhi <nchatrad@xxxxxxx> > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > --- > Changes since v1: > 1. Add "Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>" > Changes since v2: > 1. Add "Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>" > > drivers/platform/x86/amd/hsmp.c | 30 +++++++++++------------------- > 1 file changed, 11 insertions(+), 19 deletions(-)
