Thanks Ilpo On Fri, Dec 8, 2023, at 5:53 AM, Ilpo Järvinen wrote: > On Thu, 7 Dec 2023, Vishnu Sankar wrote: > > Hi Vishnu, > > Thanks for the patch. > >> Some ThinkPad systems ECFW use non-standard addresses for fan control >> and reporting. This patch adds support for such ECFW so that it can report >> the correct fan values. >> Tested on Thinkpads L13 Yoga Gen 2 and X13 Yoga Gen 2. >> >> Co-developed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx> >> Signed-off-by: Vishnu Sankar <vishnuocv@xxxxxxxxx> > > If Mark wrote any lines, his Signed-off-by is also required before yours, > as per Documentation/process/5.Posting.rst, this is a hard requirement. > > If he only helped towards the right direction/solution but provided no > code, I recommend using Suggested-by tag instead. > Ah - I didn't know that. Thanks for the clarification. I should probably be a Suggested-by here. I've been helping Vishnu with the process but he's been doing all the hard work and writing of code. Mark
