On Fri, 8 Dec 2023, Ilpo Järvinen wrote: > On Thu, 7 Dec 2023, Vishnu Sankar wrote: > > Hi Vishnu, > > Thanks for the patch. > > > Some ThinkPad systems ECFW use non-standard addresses for fan control > > and reporting. This patch adds support for such ECFW so that it can report > > the correct fan values. > > Tested on Thinkpads L13 Yoga Gen 2 and X13 Yoga Gen 2. > > > > Co-developed-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx> > > Signed-off-by: Vishnu Sankar <vishnuocv@xxxxxxxxx> > > + /* Default mode is AUTO which means controlled by EC */ > > + if (unlikely(!acpi_ec_read(fan_status_offset_ns, &s))) > > I'm skeptical that all these unlikely/likely() are useful. Some might even > be harmful if e.g. is some error condition keeps repeating itself and > the particular if handling that is marked with unlikely(). > > I know the code in that file is littered with them already but it would > be better to add into that, IMO. So I'm missing the negative here, I meant: ... not add into that ... -- i.
