Hi Andy,
I missed 1 remark:
On 9/10/23 10:24, Andy Shevchenko wrote:
>> - ret = x86_android_tablet_get_gpiod("INT33FF:02", 22, &gpiod);
>> + ret = x86_android_tablet_get_gpiod("INT33FF:02", 22, "bq25892_0_ce",
>> + true, GPIOD_OUT_HIGH, NULL);
>> if (ret < 0)
>> return ret;
>
> Hmm... Maybe better this function to return an error pointer or valid
> pointer, and in the code you choose what to do with that?
>
> ...
>
>> /* OTG pin */
>> - ret = x86_android_tablet_get_gpiod("INT33FF:03", 19, &gpiod);
>> + ret = x86_android_tablet_get_gpiod("INT33FF:03", 19, "bq25892_0_otg",
>> + false, GPIOD_OUT_LOW, NULL);
>
> Ditto.
Yes I did consider that, but x86_android_tablet_get_gpiod() already followed
the return-by-reference model and I did not want to add changing that into
the changes this patch already makes.
Regards,
Hans
