On Mon, Mar 20, 2023 at 6:05 PM Gergo Koteles <soyer@xxxxxx> wrote: > > Hi Andrew, > > Thanks for picking this up. Sorry for the late reply. > I no longer think this driver should do the same workaround as ymc.exe > does, it shouldn't make non-WMI calls. > I think the 14ARB7 should be fixed in the BIOS to work like the other > Yogas with the same WMI IDs. > > So PATCH 1/2 and codes related to ec_trigger are unnecessary. > > I only have the 14ARB7 and I can't test this without the ec_trigger. > For this reason, I don't want to be the author of this module. > Could you be the author? > > The working C940, 14API reports are from > https://github.com/lukas-w/yoga-usage-mode module, which uses the same > WMI IDs. > > Regards, > Gergo > > Co-developed-by: Gergo Koteles <soyer@xxxxxx> > Signed-off-by: Gergo Koteles <soyer@xxxxxx> Hi Gergo, happy to hear from you! Now it makes sense why this never got submitted. I suppose the 0xAB method ID came from decompiling that ymc.exe as well? It looks like the github repo uses 0x01 which is what we found in the acpidump. I will remove that code like you say, make myself the module author, and add your Co-developed-by and Signed-off-by tags to the commit. Thanks, Andrew
