Hi, On 3/16/23 19:11, Joseph, Jithu wrote: > > > On 3/16/2023 2:59 AM, Hans de Goede wrote: > >> >> After taking a closer look I do see one unrelated issue with this patch >> sysfs.c: run_test_store() does: >> >> if (!ifsd->loaded) >> rc = -EPERM; >> else >> rc = do_core_test(cpu, dev); >> >> But AFAICT the loaded check really only applies to the first (intel_ifs_0 device) test type and the >> Array BIST test should work fine when loaded is false. >> >> So I think that the if (!ifsd->loaded) error check should be moved to >> ifs_test_core() ? >> > > It is possible that I misinterpreted your comment in my earlier reply. (Thanks Tony for pointing it out) No you were right I was looking at the current code, not the code after this patch-set is applied. > Yes I think moving the load check into ifs_test_core() is better than doing it in run_test_store() Ack, doing that is still a cleaner way of dealing with this. Regards, Hans
