Hi, > Note most drivers/platform/x86 drivers do indeed use /* ... */, so I would not mind if you convert the comments Okay, I'll do it then > But I guess it might be better to put that on the TODO list somewhere and do it once the module has had some more testing. > > E.g. I should really test this on my desktop's MSI B550M PRO-VDH board and see what it does there (hopefully nothing). By design it should fail to load on your motherboard since ec_read() will return with ENODEV if EC isn't present, or read an incompatible version if it is. Some testing would be good, so we can add a DMI table in the next set of patches. I have a question about naming. We have the fn_super_swap configuration parameter, but I noticed that in the kernel code the Super key is often called Meta. Should I also rename it to fn_meta_swap or stick with 'Super'? Regards, Nikita
