Hi, > The above two functions are inconsistent with the rest of the file because > they have the return type in a separate line. I believe it was originally made to not exceed the limit of 80 columns > It's a small thing, but usually /* ... */ comments are preferred. > Hans will tell you if you need to change it. Okay > Previously you said `match_string()` works here. Has something changed? No, I implemented it in the main repo but forgot to do it in the kernel patch.. I'll do it in the v3 after we're finished reviewing v2 > Why not simply > > conf = *CONFIGURATIONS[i]; Noted Regards, Nikita
