Hi,
On 3/1/23 11:34, Andy Shevchenko wrote:
> On Wed, Mar 1, 2023 at 11:23 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>>
>> Move the info for the Asus tablets to their own asus.c file.
>
> ...
>
>> +static int __init asus_me176c_tf103c_init(void)
>> +{
>> + struct gpio_desc *gpiod;
>> + int ret;
>> +
>> + ret = x86_android_tablet_get_gpiod("INT33FC:02", 12, &gpiod);
>> + if (ret < 0)
>> + return ret;
>> + asus_me176c_tf103c_lid.gpio = desc_to_gpio(gpiod);
>
>> +
>
> I would expect this blank line to be after return ret;, but it's not a big deal.
I think it was this way before moving it around and more importantly
the "platform/x86: x86-android-tablets: Add gpio_keys support to x86_android_tablet_init()"
patch completely removes this function.
Talking about "platform/x86: x86-android-tablets: Add gpio_keys support to x86_android_tablet_init()"
I did implement your suggestions to put all the info for a button into
a separate struct, but I forgot to add a Changes section to the commit
msg for this.
Regards,
Hans
>
>> + return 0;
>> +}
>
