On Wed, Mar 1, 2023 at 11:23 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Move the info for the Asus tablets to their own asus.c file. ... > +static int __init asus_me176c_tf103c_init(void) > +{ > + struct gpio_desc *gpiod; > + int ret; > + > + ret = x86_android_tablet_get_gpiod("INT33FC:02", 12, &gpiod); > + if (ret < 0) > + return ret; > + asus_me176c_tf103c_lid.gpio = desc_to_gpio(gpiod); > + I would expect this blank line to be after return ret;, but it's not a big deal. > + return 0; > +} -- With Best Regards, Andy Shevchenko