On Wed, Mar 1, 2023 at 12:23 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > On 3/1/23 11:17, Andy Shevchenko wrote: > > On Wed, Mar 1, 2023 at 11:23 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > >> > >> Move the helpers to get irqs + gpios as well as the core code for > > > > IRQs > > GPIOs > > Ack I'll amend the commit msg. > > > > >> instantiating all the devices missing from ACPI into a new core.c file. > > > > ... > > > >> + for (i = 0; gpiod_lookup_tables && gpiod_lookup_tables[i]; i++) > >> + gpiod_remove_lookup_table(gpiod_lookup_tables[i]); > > > > Do we have an API to remove a bunch of tables at once? > > > > ... > > > >> + gpiod_lookup_tables = dev_info->gpiod_lookup_tables; > >> + for (i = 0; gpiod_lookup_tables && gpiod_lookup_tables[i]; i++) > >> + gpiod_add_lookup_table(gpiod_lookup_tables[i]); > > > > This seems like open coded gpiod_add_lookup_tables(). > > This is just moving code, not refactoring it. The intend is very much > to NOT make any code changes here. OK! Then it might be a new patch in the future :-) -- With Best Regards, Andy Shevchenko
