Re: [PATCH v2 03/14] platform/x86: x86-android-tablets: Move core code into new core.c file

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Wed, Mar 1, 2023 at 11:23 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Move the helpers to get irqs + gpios as well as the core code for

IRQs
GPIOs

> instantiating all the devices missing from ACPI into a new core.c file.

...

> +       for (i = 0; gpiod_lookup_tables && gpiod_lookup_tables[i]; i++)
> +               gpiod_remove_lookup_table(gpiod_lookup_tables[i]);

Do we have an API to remove a bunch of tables at once?

...

> +       gpiod_lookup_tables = dev_info->gpiod_lookup_tables;
> +       for (i = 0; gpiod_lookup_tables && gpiod_lookup_tables[i]; i++)
> +               gpiod_add_lookup_table(gpiod_lookup_tables[i]);

This seems like open coded gpiod_add_lookup_tables().

-- 
With Best Regards,
Andy Shevchenko