On 17/02/2023 12:31, Enrico Weigelt, metux IT consult wrote: > On 17.01.23 11:25, Hans de Goede wrote: > >> Enrico, can you take a look at this series please? You can find >> the 2 actual patches here: >> >> https://lore.kernel.org/platform-driver-x86/20230113231139.436956-1-philipp@xxxxxxxxxxxxxxxxxxxxx/ >> https://lore.kernel.org/platform-driver-x86/20230113231140.437040-1-philipp@xxxxxxxxxxxxxxxxxxxxx/ > > NAK on renaming the RST lines (at least for the older boards), this will > break existing applications in the field (I know for sure certain ones I > wrote myself - and they're used in remote places!) > > These lines (at least for the older boards) are supposed to be generic > RST lines on the mpcie ports - not strictly limited to modems - that's > why I've chosen this naming. Sure - but the *wiring* of the RST lines *follows* the modems. Can you give an example of how you are using the RST line, such that it's naming affects you please? Hans pointed out that generally it's the number order which is used? Ed W
