Hi Philip, On 1/14/23 00:11, Philip Prindeville wrote: > From: Philip Prindeville <philipp@xxxxxxxxxxxxxxxxxxxxx> > > Extend PCEngines APU2 driver to derivative models APU3, 4, 5 > and 6. > > Of the five, the APU5 is the most dissimilar. The APU2 is not > derivative of the APU1, and we call that out in the leds-apu > driver. We also clarify the expanded compatibility of the > pcengines-apuv2 driver in the Kconfig menu. > > We correct some line labeling for GPIO lines 4-6, and we add > appropriate definitions to the GPIO lines for the APU5 which > is mapped out differently. > > The majority of the work was done by Ed Wildgoose. Philip > Prindeville took over the effort to upstream the fixes and > made some minor cleanup. Thank you both for your work on this. In would really like to hear back from Enrico what he thinks about these patches. FWIW I'm fine with merging these as is. Also note that Enrico is listed as maintainer for the pcengines-apuv2.c file in MAINTAINERS, so you really should have Cc-ed him on this. Enrico, can you take a look at this series please? You can find the 2 actual patches here: https://lore.kernel.org/platform-driver-x86/20230113231139.436956-1-philipp@xxxxxxxxxxxxxxxxxxxxx/ https://lore.kernel.org/platform-driver-x86/20230113231140.437040-1-philipp@xxxxxxxxxxxxxxxxxxxxx/ Regards, Hans > > Philip Prindeville (2): > x86: Support APU5 & APU6 in PCEngines platform driver > x86: Further PCEngines APU4/5/6 cleanup > > drivers/leds/leds-apu.c | 2 +- > drivers/platform/x86/Kconfig | 4 +- > drivers/platform/x86/pcengines-apuv2.c | 118 ++++++++++++++++++++++--- > 3 files changed, 107 insertions(+), 17 deletions(-) >
