On 2/1/23 11:56, Joseph, Jithu wrote: >> Voila! Less code, less obfuscation, less duplicated effort. Or, worst > Agreed, will modify it as you suggest above to remove the duplicate zero assignments ... and the union ... and the _unnecessary_ bitfields. You can make an argument that ->ctrl_result should be a bitfield. The other structure members, not so much. Make them standalone unsigned integers. But, when it's down to a single bit in an otherwise completely unpopulated byte-sized field, your arguments for using a bitfield kinda dry up. But, heck, if that's the hill you want to die on, who am I to stop you?
