On 1/12/2023 15:06, Mark Pearson wrote:
On Thu, Jan 12, 2023, at 3:49 PM, Limonciello, Mario wrote:
[Public]
> -----Original Message-----
> From: Mark Pearson <mpearson-lenovo@xxxxxxxxx
<mailto:mpearson-lenovo@xxxxxxxxx>>
> Sent: Thursday, January 12, 2023 14:45
> To: mpearson-lenovo@xxxxxxxxx <mailto:mpearson-lenovo@xxxxxxxxx>
> Cc: hdegoede@xxxxxxxxxx <mailto:hdegoede@xxxxxxxxxx>; Limonciello, Mario
> <Mario.Limonciello@xxxxxxx <mailto:Mario.Limonciello@xxxxxxx>>;
markgross@xxxxxxxxxx <mailto:markgross@xxxxxxxxxx>; platform-driver-
> x86@xxxxxxxxxxxxxxx <mailto:x86@xxxxxxxxxxxxxxx>
> Subject: [PATCH] platform/x86: thinkpad_acpi: Remove AMT enablement
>
This title really isn't accurate is it? AMT is still there, it's
really more of a bug
fix for reporting the right profiles when AMT is active (which should
be balanced).
Shoot my bad. I did two versions of the patch - one to remove the
feature, and one to fix it.
I did some testing and the results from the fix version were better so I
updated my commit message....and missed the title. I'm an idiot.
I assume I should resend the patch with the correct title?
Probably best to do.
> Recently AMT mode was enabled (somewhat unexpectedly) on the Lenovo
> Z13 platform. The FW is advertising it is available and the driver tries
> to use it - unfortunately it reports the profile mode incorrectly.
>
> Note, there is also some extra work needed to enable the dynamic aspect
> of AMT support that I will be following up with; but more testing is
> needed first. This patch just fixes things so the profiles are reported
> correctly.
>
> Signed-off-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx
<mailto:mpearson-lenovo@xxxxxxxxx>>
With the title fixed.
Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxx
<mailto:mario.limonciello@xxxxxxx>>
Suggest this to Cc to 6.1-stable as well as it's fixing a power
profile reporting bug.
Ah - I was going to propose it to stable once it was reviewed and
accepted. Is it normal to do that on the first pass?
Mark
You can do it both ways.
https://www.kernel.org/doc/html/next/process/stable-kernel-rules.html
I was suggesting method 1 since this is a bug fix.
When you submit V2, some other things you should add (besides my tag and
fix the title):
Reported-by: <person's email if you have one>
Link: <URL where people reported this broken>
Fixes: 46dcbc61b739b ("platform/x86: thinkpad-acpi: Add support for
automatic mode transitions")
