Re: [PATCH resend] platform/x86: intel-uncore-freq: add Emerald Rapids support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Hans,

On Tue, 2022-11-22 at 16:30 +0100, Hans de Goede wrote:
There are 3 different issues with this patch, next time please
check your patch a bit more thorough before submitting it:

1. This is the first time I see this, or that the
platform-driver-x86@xxxxxxxxxxxxxxx
list sees this. Next time please make sure you address the patch to the right
people the first time you send it:

sure, thanks.

2. This has checkpatch warnings which are easily fixable:

[hans@shalem platform-drivers-x86]$ scripts/checkpatch.pl 0001-platform-x86-
intel-uncore-freq-add-Emerald-Rapids-su.patch 
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per
line)

OK.

3. This fails to build on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next

OK, thanks for the pointer. I'd need platfrom-drivers-x86 git tree to include
this upstream commit:

7beade0dd41d x86/cpu: Add several Intel server CPU model numbers

Would you please consider updating?

Thanks!




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux