Hi,
On 11/22/22 08:00, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>
>
> Make Intel uncore frequency driver support Emerald Rapids by adding its CPU
> model to the match table. Emerald Rapids uncore frequency control is the same
> as in Sapphire Rapids.
>
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> ---
>
> Re-sending the same patch, but added X86 platform maintainers.
There are 3 different issues with this patch, next time please
check your patch a bit more thorough before submitting it:
1. This is the first time I see this, or that the platform-driver-x86@xxxxxxxxxxxxxxx
list sees this. Next time please make sure you address the patch to the right
people the first time you send it:
[hans@shalem platform-drivers-x86]$ scripts/get_maintainer.pl -f drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c
Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> (maintainer:INTEL UNCORE FREQUENCY CONTROL)
Hans de Goede <hdegoede@xxxxxxxxxx> (maintainer:X86 PLATFORM DRIVERS)
Mark Gross <markgross@xxxxxxxxxx> (maintainer:X86 PLATFORM DRIVERS)
platform-driver-x86@xxxxxxxxxxxxxxx (open list:INTEL UNCORE FREQUENCY CONTROL)
linux-kernel@xxxxxxxxxxxxxxx (open list)
2. This has checkpatch warnings which are easily fixable:
[hans@shalem platform-drivers-x86]$ scripts/checkpatch.pl 0001-platform-x86-intel-uncore-freq-add-Emerald-Rapids-su.patch
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#7:
model to the match table. Emerald Rapids uncore frequency control is the same
total: 0 errors, 1 warnings, 7 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
0001-platform-x86-intel-uncore-freq-add-Emerald-Rapids-su.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
3. This fails to build on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next
which is the branch on which this needs to be applied to get upstream, so this is also
the branch on which you should base the patch (and build test it) before submitting it
upstream:
In file included from drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c:21:
./arch/x86/include/asm/cpu_device_id.h:161:46: error: ‘INTEL_FAM6_EMERALDRAPIDS_X’ undeclared here (not in a function); did you mean ‘INTEL_FAM6_SAPPHIRERAPIDS_X’?
161 | X86_MATCH_VENDOR_FAM_MODEL(INTEL, 6, INTEL_FAM6_##model, data)
| ^~~~~~~~~~~
./arch/x86/include/asm/cpu_device_id.h:46:27: note: in definition of macro ‘X86_MATCH_VENDOR_FAM_MODEL_STEPPINGS_FEATURE’
46 | .model = _model, \
| ^~~~~~
./arch/x86/include/asm/cpu_device_id.h:129:9: note: in expansion of macro ‘X86_MATCH_VENDOR_FAM_MODEL_FEATURE’
129 | X86_MATCH_VENDOR_FAM_MODEL_FEATURE(vendor, family, model, \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./arch/x86/include/asm/cpu_device_id.h:161:9: note: in expansion of macro ‘X86_MATCH_VENDOR_FAM_MODEL’
161 | X86_MATCH_VENDOR_FAM_MODEL(INTEL, 6, INTEL_FAM6_##model, data)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c:206:9: note: in expansion of macro ‘X86_MATCH_INTEL_FAM6_MODEL’
206 | X86_MATCH_INTEL_FAM6_MODEL(EMERALDRAPIDS_X, NULL),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
make[6]: *** [scripts/Makefile.build:250: drivers/platform/x86/intel/uncore-frequency/uncore-frequency.o] Error 1
Regards,
Hans
>
> drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c
> index 8f9c571d7257..00ac7e381441 100644
> --- a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c
> +++ b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c
> @@ -203,6 +203,7 @@ static const struct x86_cpu_id intel_uncore_cpu_ids[] = {
> X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_X, NULL),
> X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_D, NULL),
> X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(EMERALDRAPIDS_X, NULL),
> {}
> };
> MODULE_DEVICE_TABLE(x86cpu, intel_uncore_cpu_ids);
