Hi Jiaxun, On 11/17/22 19:26, Jiaxun Yang wrote: > > > 在2022年11月17日十一月 上午11:02,Hans de Goede写道: >> Hi All, >> >> Here is v2 of my series to rework the ideapad-laptop touchpad control code. >> >> New in v2: >> - Split patch 3/3 in to 3 patches (3-5/6) since it was doing to much at once >> - Update r_touchpad_val on sysfs read/writes >> - Drop the write(VPCCMD_W_TOUCHPAD, 1) call at probe in a separate patch >> and document why this is done in the commit msg >> - Add a new patch (6/6) to hide the touchpad sysfs attribute behind a >> module-parameter which is disabled by default, see the commit message >> for why this is done. >> > > For the whole series: > Reviewed-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> > Tested-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx> > > Can confirm this approach works fine on my problematic ideaPad Yoga 14s. Thank you for the review and for testing! I will go and add this series to my review-hans branch now and from there it will move to for-next once the builders have done a test-build of it. Regards, Hans