Hi All, Here is v2 of my series to rework the ideapad-laptop touchpad control code. New in v2: - Split patch 3/3 in to 3 patches (3-5/6) since it was doing to much at once - Update r_touchpad_val on sysfs read/writes - Drop the write(VPCCMD_W_TOUCHPAD, 1) call at probe in a separate patch and document why this is done in the commit msg - Add a new patch (6/6) to hide the touchpad sysfs attribute behind a module-parameter which is disabled by default, see the commit message for why this is done. Note this applies on top of my review-hans branch which has seen a bunch of other ideapad-laptop changes land recently: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Regards, Hans Hans de Goede (6): platform/x86: ideapad-laptop: Refactor ideapad_sync_touchpad_state() platform/x86: ideapad-laptop: Do not send KEY_TOUCHPAD* events on probe / resume platform/x86: ideapad-laptop: Only toggle ps2 aux port on/off on select models platform/x86: ideapad-laptop: Send KEY_TOUCHPAD_TOGGLE on some models platform/x86: ideapad-laptop: Stop writing VPCCMD_W_TOUCHPAD at probe time platform/x86: ideapad-laptop: Make touchpad_ctrl_via_ec a module option drivers/platform/x86/ideapad-laptop.c | 98 +++++++++++++++++---------- 1 file changed, 61 insertions(+), 37 deletions(-) -- 2.38.1