Hi! On 11/9/22 19:38, Hans de Goede wrote: > Hi Eray, > > Sorry for the long silence, I have not done any pdx86 patch review > the last 2 weeks due to personal circumstances. Oh, I wasn't even aware I had to wait for pdx86 review, and Ike Panhc just sent his Acked-By anyway, no problem at all. > On 11/9/22 13:58, Eray Orçunus wrote: > > On 11/08/22 06:56, Ike Panhc wrote: > >> > >> Thanks. Also test on my ideapad s410 and it looks good. > >> > >> Acked-by: Ike Panhc <ike.pan@xxxxxxxxxxxxx> > > > > > > Thank you :) > > > > I need some advice since I'm new in here, sadly another patch has been > > merged to ideapad-laptop along the way and currently it's not possible to > > merge patch #7, does that mean I should send v3 of my patch series? > > No that is not necessary, I can rework it to apply on top of the other > patch. Oh, that's great, thank you. > For the touchpad patches I would first like to get > a better handle on how to fix things more generic. > > Specifically patch 1/7 will cause priv->features.touchpad_ctrl_via_ec > to get set to 1 on more models and since that is causing issues > I don't think that is a good idea (even though the patch does > make sense) and for 7/7 I hope to come up with something > more generic. > > If you can run the tests from the touchpad mail soon that > would really help! That sounds great! I will try to help as much as I can. And yeah, I couldn't guess patch 1 can cause a regression on some IdeaPads. > > I think that is the only subsystem whose maintainers haven't replied yet. > > Correct, but I have replied now :) Hehe, this reply was very informative, thank you :) Best, Eray
