On Mon, Oct 31, 2022 at 08:45:35AM -0300, Joaquin Aramendia wrote:
> Hello again and thanks for the review. I submitted the patch again and
> needs some polish before it can be accepted. I had one question left:
>
> El dom, 30 oct 2022 a la(s) 00:24, Guenter Roeck (linux@xxxxxxxxxxxx) escribió:
> >
> > >>> +/* Callbacks for hwmon interface */
> > >>> +static umode_t oxp_ec_hwmon_is_visible(const void *drvdata,
> > >>> + enum hwmon_sensor_types type, u32 attr, int channel)
> > >>> +{
> > >>> + switch (type) {
> > >>> + case hwmon_fan:
> > >>> + return S_IRUGO;
> > >>> + case hwmon_pwm:
> > >>> + return S_IRUGO | S_IWUSR;
> > >>
> > >> Please use 0444 and 0644 directly. Checkpatch will tell.
> > >
> > > Oh. I did as the documentation suggested. I must confess I didn't run
> > > checkpatch, will don in the next submission.
> > >
> >
> > That is long ago. Octal values are and have been preferred for
> > several years.
>
> I've read this form here[1]. Should I send a patch to the
> Documentation to reflect the preference?
>
Sure, patches are always welcome.
Guenter
