Hi,
On 2022-08-29 00:15, kernel test robot wrote:
> Hi Arvid,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on 1c23f9e627a7b412978b4e852793c5e3c3efc555]
<snip>
> vim +/status +2992 drivers/platform/x86/toshiba_acpi.c
>
> 2984
> 2985
> 2986 /* ACPI battery hooking */
> 2987 static ssize_t charge_control_end_threshold_show(struct device *device,
> 2988 struct device_attribute *attr,
> 2989 char *buf)
> 2990 {
> 2991 int state;
>> 2992 int status;
Will be fixed in the next version, it should be used. Waiting for human feedback too first.
It would be nice to see these warnings locally, anyone know how to turn them on?
> 2993
> 2994 if (toshiba_acpi == NULL) {
> 2995 pr_err("Toshiba ACPI object invalid\n");
> 2996 return -ENODEV;
> 2997 }
> 2998
> 2999 status = toshiba_battery_charge_mode_get(toshiba_acpi, &state);
> 3000 if (state == 1)
> 3001 return sprintf(buf, "80\n");
> 3002 else
> 3003 return sprintf(buf, "100\n");
> 3004 }
> 3005
>
Best regards,
Arvid Norlander
